Integrate SecretsStoreCSI Driver (Vault Provider) as secrets source option#118
Merged
kosyfrances merged 4 commits intomainfrom Mar 11, 2025
Merged
Conversation
kosyfrances
changed the title
jkerry
previously approved these changes
Mar 7, 2025
Contributor
jkerry
left a comment
jkerry
left a comment
There was a problem hiding this comment.
The code seems fine here. I think this is a large enough update that it might deserve a readme update as well that describes how this implementation is particular to the vault CSI driver, how a vault external to TFE is required, and a configuration example.
This could also live in the standard product documentation instead of the readme as a part of this PR so I'll approve instead of request a change here. Whichever works best.
Contributor
Author
|
Thanks for the review @jkerry. I added most of the information on the docs in this helm chart, and a small snippet referencing it on the website docs. The PR is open here - https://github.com/hashicorp/ptfe-releases/pull/2248 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira
This PR includes SecretsStoreCSI Driver (vault provider) as secrets source option in TFE Helm template.
How this was tested and validated is documented on this spike doc.